Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust dfget download log #564

Merged
merged 3 commits into from
Aug 19, 2021
Merged

fix: adjust dfget download log #564

merged 3 commits into from
Aug 19, 2021
+13 −8

Conversation

garfield009
Copy link
Collaborator

Signed-off-by: zuozheng.hzz zuozheng.hzz@alibaba-inc.com

Description

Related Issue

#563

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@garfield009
fix: adjust dfget download log
f803671 
Signed-off-by: zuozheng.hzz <zuozheng.hzz@alibaba-inc.com>
@garfield009 garfield009 added this to the v2.0.0 milestone Aug 19, 2021
@garfield009 garfield009 self-assigned this Aug 19, 2021
@garfield009 garfield009 requested a review from a team as a code owner August 19, 2021 08:07
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021 •
edited
Loading

Codecov Report

Merging #564 (f803671) into main (dddf241) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   39.33%   39.35%   +0.01%     
==========================================
  Files          86       86              
  Lines        6640     6640              
==========================================
+ Hits         2612     2613       +1     
- Misses       3657     3658       +1     
+ Partials      371      369       -2
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.35% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/dfget/dfget.go 15.32% <50.00%> (ø)
client/daemon/peer/peertask_stream.go 56.09% <0.00%> (-1.40%) ⬇️
client/daemon/peer/peertask_base.go 35.31% <0.00%> (+0.63%) ⬆️
client/daemon/peer/piece_manager.go 67.98% <0.00%> (+0.79%) ⬆️

244372610
244372610 previously approved these changes Aug 19, 2021
View reviewed changes
@garfield009
fix: adjust dfget console log
c2288bf 
Signed-off-by: zuozheng.hzz <zuozheng.hzz@alibaba-inc.com>
@garfield009
fix: adjust dfget console log
d564b8a 
Signed-off-by: zuozheng.hzz <zuozheng.hzz@alibaba-inc.com>
@garfield009 garfield009 requested a review from 244372610 August 19, 2021 08:37
gaius-qi
gaius-qi requested changes Aug 19, 2021
View reviewed changes
cmd/dfget/cmd/root.go Show resolved Hide resolved
gaius-qi
gaius-qi approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit dfb7f1e into main Aug 19, 2021
@gaius-qi gaius-qi deleted the feature/dfget-console-log branch August 19, 2021 10:19
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@garfield009 @gaius-qi
fix: adjust dfget download log (#564)
cddd25e 
* fix: adjust dfget download log

Signed-off-by: zuozheng.hzz <zuozheng.hzz@alibaba-inc.com>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
@dependabot
chore(deps): Bump dashmap from 5.5.3 to 6.0.1 (dragonflyoss#564)
3933e12 
Bumps [dashmap](https://github.com/xacrimon/dashmap) from 5.5.3 to 6.0.1.
- [Release notes](https://github.com/xacrimon/dashmap/releases)
- [Commits](xacrimon/dashmap@v.5.5.3...v6.0.1)

---
updated-dependencies:
- dependency-name: dashmap
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

@244372610 244372610 244372610 approved these changes

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474

Assignees

@garfield009 garfield009

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@garfield009 @codecov-commenter @gaius-qi @244372610